Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using the TOX_ENV_NAME variable #15528

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Stop using the TOX_ENV_NAME variable #15528

merged 5 commits into from
Aug 10, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Aug 10, 2023 •
edited
Loading

What does this PR do?

Stop using the TOX_ENV_NAME variable from ddev

Motivation

We do not use tox anymore, we only use hatch now

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@FlorentClarret FlorentClarret marked this pull request as ready for review August 10, 2023 06:55
@FlorentClarret FlorentClarret requested a review from a team as a code owner August 10, 2023 06:55
@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #15528 (f3e3e2a) into master (02b2a79) will increase coverage by 1.25%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Flag Coverage Δ
activemq_xml 82.31% <ø> (ø)
ambari 85.75% <ø> (ø)
apache 95.08% <ø> (ø)
arangodb 98.23% <ø> (ø)
argocd 88.04% <ø> (ø)
aspdotnet 100.00% <ø> (ø)
avi_vantage 91.35% <ø> (ø)
azure_iot_edge 82.08% <ø> (ø)
boundary 100.00% <ø> (ø)
btrfs 82.91% <ø> (ø)
cacti 87.90% <ø> (ø)
calico 84.61% <ø> (ø)
cert_manager 77.41% <ø> (ø)
cisco_aci 95.27% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
cloud_foundry_api 96.35% <ø> (+0.12%) ⬆️
cloudera 99.49% <ø> (ø)
cockroachdb 91.52% <ø> (ø)
coredns 94.57% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_checks_base 89.22% <ø> (+8.70%) ⬆️
datadog_checks_downloader 81.65% <ø> (ø)
datadog_cluster_agent 90.19% <ø> (ø)
dcgm 97.33% <ø> (ø)
ddev 99.46% <ø> (ø)
directory 95.87% <ø> (+0.65%) ⬆️
disk 89.23% <ø> (-2.14%) ⬇️
dns_check 93.90% <ø> (ø)
dotnetclr 91.39% <ø> (+12.90%) ⬆️
druid 98.47% <ø> (ø)
ecs_fargate 82.91% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
envoy 95.30% <ø> (+0.62%) ⬆️
external_dns 89.28% <ø> (ø)
fluentd 94.77% <ø> (ø)
foundationdb 78.50% <ø> (ø)
gitlab_runner 91.94% <ø> (ø)
go_expvar 92.73% <ø> (ø)
harbor 80.04% <ø> (ø)
hazelcast 92.39% <ø> (ø)
hdfs_namenode 86.72% <ø> (ø)
ibm_ace 91.79% <ø> (ø)
ibm_i 81.91% <ø> (ø)
impala 97.97% <ø> (ø)
kube_apiserver_metrics 97.85% <ø> (ø)
kube_controller_manager 96.03% <ø> (ø)
kube_dns 95.97% <ø> (ø)
kube_metrics_server 94.87% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kube_scheduler 96.53% <ø> (ø)
kubelet 91.00% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linkerd 85.14% <ø> (+1.14%) ⬆️
linux_proc_extras 96.22% <ø> (ø)
mapreduce 81.81% <ø> (+0.46%) ⬆️
marathon 83.43% <ø> (ø)
mcache 93.50% <ø> (ø)
mesos_master 89.75% <ø> (ø)
mesos_slave 93.63% <ø> (ø)
nagios 89.01% <ø> (ø)
network 93.09% <ø> (+0.54%) ⬆️
nfsstat 95.20% <ø> (ø)
openldap 96.79% <ø> (ø)
openmetrics 98.08% <ø> (ø)
openstack 51.45% <ø> (ø)
openstack_controller 91.12% <ø> (ø)
php_fpm 90.25% <ø> (+0.84%) ⬆️
powerdns_recursor 96.65% <ø> (ø)
process 85.42% <ø> (+0.28%) ⬆️
prometheus 94.17% <ø> (ø)
proxysql 98.97% <ø> (ø)
pulsar 100.00% <ø> (ø)
rethinkdb 97.93% <ø> (ø)
silk 93.82% <ø> (ø)
squid 100.00% <ø> (ø)
statsd 87.36% <ø> (+1.05%) ⬆️
strimzi 89.70% <ø> (ø)
system_core 90.90% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 91.58% <ø> (ø)
teamcity 88.74% <ø> (+3.21%) ⬆️
temporal 100.00% <ø> (ø)
teradata 94.06% <ø> (ø)
tokumx 58.40% <ø> (ø)
torchserve 97.33% <ø> (ø)
traffic_server 96.13% <ø> (ø)
twemproxy 79.45% <ø> (ø)
twistlock 79.62% <ø> (ø)
varnish 84.39% <ø> (+0.26%) ⬆️
windows_performance_counters 98.36% <ø> (ø)
wmi_check 92.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@DataDog DataDog deleted a comment from dd-devflow bot Aug 10, 2023
@FlorentClarret FlorentClarret requested a review from a team as a code owner August 10, 2023 07:03
@ghost ghost added the documentation label Aug 10, 2023
iliakur
iliakur previously approved these changes Aug 10, 2023
View reviewed changes
@github-actions
Copy link

Test Results

     989 files       989 suites   7h 53m 6s ⏱️
  5 869 tests   5 795 ✔️      73 💤 1 ❌
24 270 runs  19 998 ✔️ 4 271 💤 1 ❌

For more details on these failures, see this check.

Results for commit d46333d.

drichards-87
drichards-87 previously approved these changes Aug 10, 2023
View reviewed changes
@FlorentClarret FlorentClarret force-pushed the florentclarret/ddev/tox_env_name branch from d46333d to 58cae49 Compare August 10, 2023 14:53
@FlorentClarret FlorentClarret merged commit 2719f7d into master Aug 10, 2023
312 of 314 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/ddev/tox_env_name branch August 10, 2023 15:26
@vivek-datadog vivek-datadog added the qa/skip-qa Automatically skip this PR for the next QA label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliakur iliakur iliakur approved these changes

@drichards-87 drichards-87 drichards-87 left review comments

Assignees
No one assigned
Labels
dev_package dev/tooling documentation qa/skip-qa Automatically skip this PR for the next QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FlorentClarret @iliakur @drichards-87 @vivek-datadog